Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Date: 2021-04-23 07:10:37
Message-ID: 98e3f922-629f-fe53-6027-3c668a9a0f70@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/04/22 18:23, Julien Rouhaud wrote:
> On Thu, Apr 22, 2021 at 12:28:11AM +0900, Fujii Masao wrote:
>>
>> I found another small issue in pg_stat_statements docs. The following
>> description in the docs should be updated so that toplevel is included?
>>
>>> This view contains one row for each distinct database ID, user ID and query ID
>
> Indeed! I'm adding Magnus in Cc.
>
> PFA a patch to fix at, and also mention that toplevel will only
> contain True values if pg_stat_statements.track is set to top.

Thanks for the patch! LGTM.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-04-23 07:30:27 Re: wal stats questions
Previous Message wangyukun@fujitsu.com 2021-04-23 07:03:40 RE: fix a comment