| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, jiye_sw(at)126(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17633: Define rule on views which do insert to another relation trigger cache lookup failed error. |
| Date: | 2022-10-11 16:16:37 |
| Message-ID: | MEYP282MB16690E8D4FCC095086FC9242B6239@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, 11 Oct 2022 at 23:37, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> I think the basic problem is that the two calls of rewriteValuesRTE
>> are really dealing with fundamentally different cases, and we should
>> probably not have tried to make the same function do both. I'm going
>> to try splitting it into two functions, one for the force_nulls case
>> and one for the !force_nulls case.
>
> As attached. This seems *way* cleaner to me, even if it means we need
> two copies of the loops-over-VALUES-list-entries. I didn't write a
> regression test yet, but this fixes the submitted bug and passes
> check-world.
>
Great. LGTM. Should we add the test-case for this?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| Attachment | Content-Type | Size |
|---|---|---|
| test-case-for-bug-17633.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2022-10-11 18:28:51 | BUG #17635: The behavior of quote_ident differs from what the doc specifies |
| Previous Message | Blum, Kimber | 2022-10-11 15:57:29 | RE: BUG #17634: Inconsistent view_definition in information_schema.views |