Re: type in basebackup_incremental.c ?

>Sent: Thursday, April 11, 2024 12:15
>To: Daniel Westermann (DWE) <daniel(dot)westermann(at)dbi-services(dot)com>
>Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
>Subject: Re: type in basebackup_incremental.c ?
>
>> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel(dot)westermann(at)dbi-services(dot)com> wrote:
>>
>> Hi,
>>
>> /*
>> * we expect the find the last lines of the manifest, including the checksum,
>> * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
>> * parse step if we are about to overflow MAX_CHUNK bytes.
>> */
>>
>> Shouldn't this be:
>> /*
>> * we expect to find the last lines of the manifest,...
>> */

>That sounds about right, and since it's a full sentence it should also start
>with a capital 'W': "We expect to find the..".

... and a bit further down:

* We don't really need this information, because we use WAL summaries to
* figure what's changed.

Should probably be: ...because we use WAL summaries to figure out ...

Regards
Daniel