| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: type in basebackup_incremental.c ? |
| Date: | 2024-04-11 11:16:02 |
| Message-ID: | 33eb9877-5044-4fe7-8e71-f614945abea6@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-04-11 Th 06:15, Daniel Gustafsson wrote:
>> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel(dot)westermann(at)dbi-services(dot)com> wrote:
>>
>> Hi,
>>
>> /*
>> * we expect the find the last lines of the manifest, including the checksum,
>> * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
>> * parse step if we are about to overflow MAX_CHUNK bytes.
>> */
>>
>> Shouldn't this be:
>> /*
>> * we expect to find the last lines of the manifest,...
>> */
> That sounds about right, and since it's a full sentence it should also start
> with a capital 'W': "We expect to find the..".
>
Thanks, I will include that in the cleanups I'm intending to push today.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-04-11 11:16:40 | Re: type in basebackup_incremental.c ? |
| Previous Message | Daniel Westermann (DWE) | 2024-04-11 11:00:31 | Re: type in basebackup_incremental.c ? |