Re: type in basebackup_incremental.c ?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: type in basebackup_incremental.c ?
Date: 2024-04-11 10:15:26
Message-ID: 6946EFB1-626A-41B6-AE42-2C12950455EB@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel(dot)westermann(at)dbi-services(dot)com> wrote:
>
> Hi,
>
> /*
> * we expect the find the last lines of the manifest, including the checksum,
> * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
> * parse step if we are about to overflow MAX_CHUNK bytes.
> */
>
> Shouldn't this be:
> /*
> * we expect to find the last lines of the manifest,...
> */

That sounds about right, and since it's a full sentence it should also start
with a capital 'W': "We expect to find the..".

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-04-11 10:26:38 Re: post-freeze damage control
Previous Message Daniel Westermann (DWE) 2024-04-11 09:49:54 type in basebackup_incremental.c ?