Re: pgsql: Add TAP tests for timeouts

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, akorotkov(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add TAP tests for timeouts
Date: 2024-03-15 12:25:24
Message-ID: F719524D-ACE0-474D-8E45-229EFE5AE195@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 15 Mar 2024, at 16:30, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> Maybe, but do you see any negative side effects of the unconditionally
> unset of flags?

Nope, just expressed possible option.

> If not, I would prefer to keep the code simple.

IMO that's fine. Let's incorporate wording improvement from Kyotaro to the same patch? PFA draft for this.

Maybe it worth to wait a little to see if some other failures will pop up?

Best regards, Andrey Borodin.

Attachment Content-Type Size
v2-0001-Fix-race-condition-in-transaction-timeout-TAP-tes.patch application/octet-stream 4.3 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-03-15 12:50:41 pgsql: Fix wordings in timeouts TAP test
Previous Message Alexander Korotkov 2024-03-15 11:30:28 Re: pgsql: Add TAP tests for timeouts