| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, akorotkov(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add TAP tests for timeouts |
| Date: | 2024-03-15 12:54:34 |
| Message-ID: | CAPpHfdv=dr6bE_UyaJivOLgvdVj-1V4UWwD5rmkaURBNirhGEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Mar 15, 2024 at 2:25 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> > On 15 Mar 2024, at 16:30, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > Maybe, but do you see any negative side effects of the unconditionally
> > unset of flags?
>
> Nope, just expressed possible option.
>
> > If not, I would prefer to keep the code simple.
>
> IMO that's fine. Let's incorporate wording improvement from Kyotaro to the same patch? PFA draft for this.
Thank you, I've pushed this, but split into two commits for bugfix and
for improved wordings.
> Maybe it worth to wait a little to see if some other failures will pop up?
I prefer to push now because we're quite confident this fix will
improve the situation. It should increase the chances of catching
other bugs if any, because buildfarm which was failing on this bug
will go ahead and have a chance to spot more.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-03-15 13:22:25 | pgsql: Try to unbreak injection-fault tests in the buildfarm |
| Previous Message | Alexander Korotkov | 2024-03-15 12:50:41 | pgsql: Fix race condition in transaction timeout TAP tests |