| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, akorotkov(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add TAP tests for timeouts |
| Date: | 2024-03-15 11:30:28 |
| Message-ID: | CAPpHfdvAFor_8cftdNtXvnDAyVmv77AwtLGyEa+Gb5FVMbjZ6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Mar 15, 2024 at 1:27 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> > On 15 Mar 2024, at 15:44, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > We loop in the interrupt checking, given that the injection point handler checks for interrupts internally. I propose to unset the timeout flag before the injection point (see the attached patch).
>
> Oh, cool.
> As far as I understand, this is only necessary for the test with injection point.
> So, maybe unset it only when injection points are enabled? Something like this is already used in GIN.
>
> #ifdef USE_INJECTION_POINTS
> ....
> #endif
Maybe, but do you see any negative side effects of the unconditionally
unset of flags? If not, I would prefer to keep the code simple.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-03-15 12:25:24 | Re: pgsql: Add TAP tests for timeouts |
| Previous Message | Andrey M. Borodin | 2024-03-15 11:27:02 | Re: pgsql: Add TAP tests for timeouts |