Re: pgsql: Add TAP tests for timeouts

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, akorotkov(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add TAP tests for timeouts
Date: 2024-03-15 11:27:02
Message-ID: 91C963B5-63CC-4FAE-9119-E226CF84112A@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 15 Mar 2024, at 15:44, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> We loop in the interrupt checking, given that the injection point handler checks for interrupts internally. I propose to unset the timeout flag before the injection point (see the attached patch).

Oh, cool.
As far as I understand, this is only necessary for the test with injection point.
So, maybe unset it only when injection points are enabled? Something like this is already used in GIN.

#ifdef USE_INJECTION_POINTS
....
#endif

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-03-15 11:30:28 Re: pgsql: Add TAP tests for timeouts
Previous Message Heikki Linnakangas 2024-03-15 11:17:03 pgsql: Improve log messages referring to background worker processes