pgsql: Improve wording of two error messages related to generated colum

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve wording of two error messages related to generated colum
Date: 2020-11-23 16:15:26
Message-ID: E1khEUw-0003ve-0R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve wording of two error messages related to generated columns.

Clarify that you can "insert" into a generated column as long as what
you're inserting is a DEFAULT placeholder.

Also, use ERRCODE_GENERATED_ALWAYS in place of ERRCODE_SYNTAX_ERROR;
there doesn't seem to be any reason to use the less specific errcode.

Discussion: https://postgr.es/m/9q0sgcr416t.fsf@gmx.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d36228a9fcdccd57a7dc332572eb9837c7c301e6

Modified Files
--------------
src/backend/rewrite/rewriteHandler.c | 17 ++++++++++-------
src/test/regress/expected/generated.out | 20 ++++++++++----------
src/test/regress/expected/identity.out | 12 ++++++------
src/test/regress/expected/updatable_views.out | 4 ++--
4 files changed, 28 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-11-23 16:38:48 pgsql: Rename the "point is strictly above/below point" comparison oper
Previous Message Alvaro Herrera 2020-11-23 16:10:48 pgsql: Make some sanity-check elogs more verbose