pgsql: Rename the "point is strictly above/below point" comparison oper

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rename the "point is strictly above/below point" comparison oper
Date: 2020-11-23 16:38:48
Message-ID: E1khErY-00043P-5q@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename the "point is strictly above/below point" comparison operators.

Historically these were called >^ and <^, but that is inconsistent
with the similar box, polygon, and circle operators, which are named
|>> and <<| respectively. Worse, the >^ and <^ names are used for
*not* strict above/below tests for the box type.

Hence, invent new operators following the more common naming. The
old operators remain available for now, and are still accepted by
the relevant index opclasses too. But there's a deprecation notice,
so maybe we can get rid of them someday.

Emre Hasegeli, reviewed by Pavel Borisov

Discussion: https://postgr.es/m/24348.1587444160@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0cc99327888840f2bf572303b68438e4caf62de9

Modified Files
--------------
doc/src/sgml/func.sgml | 46 +++++---------
doc/src/sgml/gist.sgml | 4 +-
doc/src/sgml/spgist.sgml | 14 ++---
src/backend/access/gist/gistproc.c | 12 +++-
src/backend/access/spgist/spgkdtreeproc.c | 2 +
src/backend/access/spgist/spgquadtreeproc.c | 4 ++
src/include/access/stratnum.h | 4 +-
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_amop.dat | 30 +++++++--
src/include/catalog/pg_operator.dat | 13 +++-
src/test/regress/expected/create_index.out | 16 ++---
src/test/regress/expected/create_index_spgist.out | 76 +++++++++++------------
src/test/regress/expected/opr_sanity.out | 8 +--
src/test/regress/expected/point.out | 6 +-
src/test/regress/sql/create_index.sql | 12 ++--
src/test/regress/sql/create_index_spgist.sql | 36 +++++------
src/test/regress/sql/point.sql | 6 +-
17 files changed, 159 insertions(+), 132 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2020-11-23 21:56:40 pgsql: Don't hold ProcArrayLock longer than needed in rare cases
Previous Message Tom Lane 2020-11-23 16:15:26 pgsql: Improve wording of two error messages related to generated colum