| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Make some sanity-check elogs more verbose |
| Date: | 2020-11-23 16:10:48 |
| Message-ID: | E1khEQS-0003tM-5Q@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Make some sanity-check elogs more verbose
A few sanity checks in funcapi.c were not mentioning all the possible
clauses for failure, confusing developers who fat-fingered catalog data
additions. Make the errors more detailed to avoid wasting time in
pinpointing mistakes.
Per complaint from Craig Ringer.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAMsr+YH7Kd87A3cU5m_wKo46HPQ46zFv5wesFNL0YWxkGhGv3g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fe051291550ab88267ce3104e9833925bf757393
Modified Files
--------------
src/backend/utils/fmgr/funcapi.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-11-23 16:15:26 | pgsql: Improve wording of two error messages related to generated colum |
| Previous Message | Heikki Linnakangas | 2020-11-23 09:36:43 | pgsql: Fix a few comments that referred to copy.c. |