pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c
Date: 2017-05-15 10:29:17
Message-ID: E1dADFd-0003nz-9W@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

While building runtime with QtWebEngine, we found 2 compilation errors which were introduced in a previous commit in runtime:

We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement.
"triggerAction" on WebPage is only required for Qt > 5 with WebKit only. Not required for WebEngine so added that condition.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07b06348ab487a54077e6fa3aaa16d25c51f6f82
Author: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>

Modified Files
--------------
runtime/BrowserWindow.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-05-15 10:29:24 Re: [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine
Previous Message Surinder Kumar 2017-05-15 09:56:06 Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data