| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine |
| Date: | 2017-05-15 10:29:24 |
| Message-ID: | CA+OCxoy19b0-m3N1huQrOL59a+SqzrUoNjBWUWr0J6L_tk0aHQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, applied.
On Mon, May 15, 2017 at 10:48 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:
> Hi Dave,
>
> While building runtime with QtWebEngine, we found 2 compilation errors
> which was introduced due to previous commit in runtime.
>
> - We set "setNetworkAccessManager" in WebEnginePage which was only
> required for Webkit so removed that statement.
> - "triggerAction" on WebPage is only required for Qt > 5 with WebKit
> only. Not required for WebEngine so added that condition.
>
> Please find attached fix for the same. Do review it and let me know for
> any queries.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-05-15 11:25:31 | pgAdmin 4 commit: Bump version in preparation for release. |
| Previous Message | Dave Page | 2017-05-15 10:29:17 | pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c |