| From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine |
| Date: | 2017-05-15 09:48:53 |
| Message-ID: | CACCA4P361W5ae6GQWjK1Ec4y38TmcmWqGDK+6YbFrS1Uff6QdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
While building runtime with QtWebEngine, we found 2 compilation errors
which was introduced due to previous commit in runtime.
- We set "setNetworkAccessManager" in WebEnginePage which was only
required for Webkit so removed that statement.
- "triggerAction" on WebPage is only required for Qt > 5 with WebKit
only. Not required for WebEngine so added that condition.
Please find attached fix for the same. Do review it and let me know for any
queries.
Thanks,
Neel Patel
| Attachment | Content-Type | Size |
|---|---|---|
| QtWebEngine_Compilation_Fix.patch | application/octet-stream | 984 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2017-05-15 09:56:06 | Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data |
| Previous Message | Dave Page | 2017-05-15 09:16:34 | Re: [pgAdmin4][PATCH] To fix the issue with Node rename |