pgsql: postgres_fdw: Promote an Assert() to elog().

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Promote an Assert() to elog().
Date: 2016-06-14 13:00:26
Message-ID: E1bCnxC-0007Cb-Mo@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Promote an Assert() to elog().

Andreas Seltenreich reports that it is possible for a PlaceHolderVar
to creep into this tlist, and I fear that even after that's fixed we
might have other, similar bugs in this area either now or in the
future. There's a lot of action-at-a-distance here, because the
validity of this assertion depends on core planner behavior; so, let's
use elog() to make sure we catch this even in non-assert builds,
rather than just crashing.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/332fdbef20b5b5f2588447793dbcc3bb9b88eb51

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-06-14 14:47:11 pgsql: Minor fixes in contrib installation scripts.
Previous Message Tom Lane 2016-06-13 17:53:41 pgsql: Fix multiple minor infelicities in aclchk.c error reports.