pgsql: Minor fixes in contrib installation scripts.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Minor fixes in contrib installation scripts.
Date: 2016-06-14 14:47:11
Message-ID: E1bCpcV-0000X0-6H@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Minor fixes in contrib installation scripts.

Extension scripts should never use CREATE OR REPLACE for initial object
creation. If there is a collision with a pre-existing (probably
user-created) object, we want extension installation to fail, not silently
overwrite the user's object. Bloom and sslinfo both violated this precept.

Also fix a number of scripts that had no standard header (the file name
comment and the \echo...\quit guard). Probably the \echo...\quit hack
is less important now than it was in 9.1 days, but that doesn't mean
that individual extensions get to choose whether to use it or not.

And fix a couple of evident copy-and-pasteos in file name comments.

No need for back-patch: the REPLACE bugs are both new in 9.6, and the
rest of this is pretty much cosmetic.

Andreas Karlsson and Tom Lane

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5484c0a9806b3e90b483128bc386054fc432cb65

Modified Files
--------------
contrib/bloom/bloom--1.0.sql | 7 ++++++-
contrib/hstore_plperl/hstore_plperl--1.0.sql | 5 +++++
contrib/hstore_plperl/hstore_plperlu--1.0.sql | 5 +++++
contrib/hstore_plpython/hstore_plpython2u--1.0.sql | 5 +++++
contrib/hstore_plpython/hstore_plpython3u--1.0.sql | 5 +++++
contrib/hstore_plpython/hstore_plpythonu--1.0.sql | 5 +++++
contrib/ltree_plpython/ltree_plpython2u--1.0.sql | 5 +++++
contrib/ltree_plpython/ltree_plpython3u--1.0.sql | 5 +++++
contrib/ltree_plpython/ltree_plpythonu--1.0.sql | 5 +++++
contrib/pgcrypto/pgcrypto--1.3.sql | 2 +-
contrib/pgrowlocks/pgrowlocks--1.2.sql | 2 +-
contrib/pgstattuple/pgstattuple--1.4.sql | 2 +-
contrib/sslinfo/sslinfo--1.0--1.1.sql | 2 +-
13 files changed, 50 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-06-14 15:50:15 pgsql: postgres_fdw: Check PlaceHolderVars before pushing down a join.
Previous Message Robert Haas 2016-06-14 13:00:26 pgsql: postgres_fdw: Promote an Assert() to elog().