pgsql: Fix multiple minor infelicities in aclchk.c error reports.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix multiple minor infelicities in aclchk.c error reports.
Date: 2016-06-13 17:53:41
Message-ID: E1bCW3R-0005PG-3k@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix multiple minor infelicities in aclchk.c error reports.

pg_type_aclmask reported the wrong type's OID when complaining that
it could not find a type's typelem. It also failed to provide a
suitable errcode when the initially given OID doesn't exist (which
is a user-facing error, since that OID can be user-specified).
pg_foreign_data_wrapper_aclmask and pg_foreign_server_aclmask likewise
lacked errcode specifications. Trivial cosmetic adjustments too.

The wrong-type-OID problem was reported by Petru-Florin Mihancea in
bug #14186; the other issues noted by me while reading the code.
These errors all seem to be aboriginal in the respective routines, so
back-patch as necessary.

Report: <20160613163159(dot)5798(dot)52928(at)wrigleys(dot)postgresql(dot)org>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/783cb6e48b29a34b2cefc401a72d4cc86fa6b2a6

Modified Files
--------------
src/backend/catalog/aclchk.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-06-14 13:00:26 pgsql: postgres_fdw: Promote an Assert() to elog().
Previous Message Tom Lane 2016-06-13 16:59:33 pgsql: In planner.c, avoid assuming that all PathTargets have sortgroup