From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Fix file selection on Windows. Fixes #1319 |
Date: | 2016-06-10 16:06:26 |
Message-ID: | E1bBOx0-00053P-8m@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fix file selection on Windows. Fixes #1319
1) Unable to select sql file through query tool on windows OS. In file_manager.js, we are stripping initial slash '/' from the path obtained, but we should not strip if it is full path like 'c:/path/to/dir/filename.ext'
2) Handle directory path if STORAGE_DIR is None. Proper checks are added.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e8e3fc78755df29ac466234c880d848894eebab
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Modified Files
--------------
web/pgadmin/misc/file_manager/__init__.py | 4 +++-
.../templates/file_manager/js/file_manager.js | 22 ++++++++++++++++------
web/pgadmin/tools/sqleditor/__init__.py | 2 ++
web/pgadmin/utils/paths.py | 6 +++---
4 files changed, 24 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-10 16:06:35 | Re: [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system |
Previous Message | Dave Page | 2016-06-10 15:56:08 | Re: PATCH: Reset view/layout (pgAdmin4) |