Re: PATCH: Reset view/layout (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Reset view/layout (pgAdmin4)
Date: 2016-06-10 15:56:08
Message-ID: CA+OCxoyWSzGdERwv-U3gnnWqVoemn7eCPaXF32OSg-w1WxO=Jw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Thu, Jun 9, 2016 at 8:47 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA updated patch, I have shifted it to File menu.
> Please review.
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jun 8, 2016 at 5:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Wed, Jun 8, 2016 at 12:41 PM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to add reset view/layout.
>> > Please review.
>> >
>> > RM#1248
>>
>> This needs to go on a different menu (File?), otherwise it won't be
>> accessible when running in desktop mode.
>>
>> > - Additionally, attaching patch to fix validation issue. which was
>> > causing
>> > statistics tab to break if no node is selected on browser tree and user
>> > clicks on statistics tab.
>> > - And also observed an issue with panels causing strange errors which is
>> > already fixed by Surinder .(Patch Link)
>>
>> Both committed - thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-10 16:06:26 pgAdmin 4 commit: Fix file selection on Windows. Fixes #1319
Previous Message Dave Page 2016-06-10 15:56:01 pgAdmin 4 commit: Add a menu option to reset the layout. Fixes #1248