Re: [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system
Date: 2016-06-10 16:06:35
Message-ID: CA+OCxoyAu2Y3CZFiini2qgKwEr4XLHCisyZfZiPhdTKq=iSWqg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, committed.

On Thu, Jun 9, 2016 at 1:24 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch with fixes:
> 1) Unable to select sql file through query tool on windows OS.
> In file_manager.js, we are stripping initial slash '/' from the path
> obtained.
> but we should not strip if it is full path like
> 'c:/path/to/dir/filename.ext'
>
> 2) Handle directory path if STORAGE_DIR is None.
> proper checks are added.
>
> Please review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-10 16:08:51 pgAdmin 4 commit: Fix re-display of privileges on the grant wizard if t
Previous Message Dave Page 2016-06-10 16:06:26 pgAdmin 4 commit: Fix file selection on Windows. Fixes #1319