[pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system
Date: 2016-06-09 12:24:36
Message-ID: CAM5-9D_kbrs-qafjVuV4-WXNaGJwPoqV_tBvcyoytP_HXxLQqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached patch with fixes:
1) Unable to select sql file through query tool on windows OS.
In file_manager.js, we are stripping initial slash '/' from the path
obtained.
but we should not strip if it is full path like
'c:/path/to/dir/filename.ext'

2) Handle directory path if STORAGE_DIR is None.
proper checks are added.

Please review.

Thanks,
Surinder Kumar

Attachment Content-Type Size
RM#1319.patch application/octet-stream 5.0 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Priyanka Shendge 2016-06-09 12:37:08 Re: pgAdmin IV API test cases patch
Previous Message Murtuza Zabuawala 2016-06-09 08:21:05 Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4)