Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)
Date: 2016-06-02 10:43:59
Message-ID: E1F5F831-8D94-42CD-9855-B649C9C72C79@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I was not sure about all the internal representation of psycopg date/time format against python’s datetime for JSON decoding format, so I used logical OR.

Thanks,
Murtuza
> On 02-Jun-2016, at 3:10 pm, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> On Thu, Jun 2, 2016 at 12:04 PM, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com <mailto:murtuza(dot)zabuawala(at)enterprisedb(dot)com>> wrote:
> Hi,
>
> PFA patch to fix the issue in json decoding while dealing with date format, causing QueryTool to fail to render data.
> RM#1280
> Shouldn't the check have 'and' instead of 'or' bitwise operator here?
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/>
>
> http://www.linkedin.com/in/asheshvashi <http://www.linkedin.com/in/asheshvashi>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/>
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org <mailto:pgadmin-hackers(at)postgresql(dot)org>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers <http://www.postgresql.org/mailpref/pgadmin-hackers>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-06-02 12:05:50 PATCH: Fixed issue in Index node (pgAdmin4)
Previous Message Murtuza Zabuawala 2016-06-02 10:33:57 Re: PATCH: To fix the issue in type node (pgAdmin4)