Re: PATCH: To fix the issue in type node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in type node (pgAdmin4)
Date: 2016-06-02 10:33:57
Message-ID: AED5DA0A-5B75-4574-BEF7-7290B2273B2D@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

We had condition where we were validating some model objects only if it’s in sessAttrs, which I have removed it now.
Issue: we were not getting error for required fields.

Regards,
Murtuza

> On 02-Jun-2016, at 3:55 pm, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> On Thu, Jun 2, 2016 at 3:53 PM, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com <mailto:murtuza(dot)zabuawala(at)enterprisedb(dot)com>> wrote:
> Hi Ashesh,
>
> I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it.
> Can you please give some details about those validations?
>
> What was the issue, and how did you fix it?
>
>
> Thanks,
> Murtuza.
>
>> On 02-Jun-2016, at 3:40 pm, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com <mailto:ashesh(dot)vashi(at)enterprisedb(dot)com>> wrote:
>>
>> On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com <mailto:murtuza(dot)zabuawala(at)enterprisedb(dot)com>> wrote:
>> Hi,
>>
>> PFA patch to fix the issue when throwing "Internal server error" on adding Privileges
>> (RM#1273)
>>
>> The patch contains multiple fixes in the Type node.
>> Can you please explain, what these changes are for?
>>
>> --
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/>
>>
>> http://www.linkedin.com/in/asheshvashi <http://www.linkedin.com/in/asheshvashi>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/>
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org <mailto:pgadmin-hackers(at)postgresql(dot)org>)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers <http://www.postgresql.org/mailpref/pgadmin-hackers>
>>
>>
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-06-02 10:43:59 Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)
Previous Message Ashesh Vashi 2016-06-02 10:25:10 Re: PATCH: To fix the issue in type node (pgAdmin4)