Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Fix the issue in JSON decoding (pgAdmin4)
Date: 2016-06-03 10:25:37
Message-ID: CAG7mmoxdY_KzbnOm_nKK+=KpBuHsQCMrQ9h_NKrwVwxyb=zkDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

At the moment - I have committed the code, but - I think, we should rely on
some external utility to make it work better with date, timestamp, etc.

Please take a look at this mail-chain.
https://www.postgresql.org/message-id/87mvnauugi.fsf%40metapensiero.it

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Thu, Jun 2, 2016 at 4:13 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> I was not sure about all the internal representation of psycopg date/time
> format against python’s datetime for JSON decoding format, so I used
> logical OR.
>
> Thanks,
> Murtuza
>
> On 02-Jun-2016, at 3:10 pm, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
> wrote:
>
> On Thu, Jun 2, 2016 at 12:04 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue in json decoding while dealing with date
>> format, causing QueryTool to fail to render data.
>> RM#1280
>>
> Shouldn't the check have 'and' instead of 'or' bitwise operator here?
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-06-03 10:25:46 pgAdmin 4 commit: Fixes #1280 - Resolved issue in json encoding while d
Previous Message Dave Page 2016-06-03 10:20:24 pgAdmin 4 commit: Let's make it Beta 1