| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)enterprisedb(dot)com>, Alex Wang <alex(dot)wang(at)enterprisedb(dot)com> |
| Subject: | Re: Index AM API cleanup |
| Date: | 2024-09-03 17:26:11 |
| Message-ID: | D61A1756-7B75-46B4-9BBE-FC9F98B41198@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 3, 2024, at 9:52 AM, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> Here is a cleaned-up version of the v17-0004 patch. I have applied the renaming discussed above. I have also made a wrapper function btgettreeheight() that calls _bt_getrootheight(). That way, if we ever want to change the API, we don't have to change _bt_getrootheight(), or disentangle it then. I've also added documentation and put in a source code comment that the API could be expanded for additional uses.
Ok.
> Also, I have removed the addition to the IndexOptInfo struct; that didn't seem necessary.
Good catch. I agree with the change.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2024-09-03 17:50:11 | Re: Use read streams in pg_visibility |
| Previous Message | Jacob Champion | 2024-09-03 17:20:31 | Re: Proposal for implementing OCSP Stapling in PostgreSQL |