| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use read streams in pg_visibility |
| Date: | 2024-09-03 17:50:11 |
| Message-ID: | 20240903175011.cd@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 02, 2024 at 03:20:12PM +0300, Nazir Bilal Yavuz wrote:
> Thanks, updated patches are attached.
> +/*
> + * Ask the callback which block it would like us to read next, with a small
> + * buffer in front to allow read_stream_unget_block() to work and to allow the
> + * fast path to skip this function and work directly from the array.
> */
> static inline BlockNumber
> read_stream_get_block(ReadStream *stream, void *per_buffer_data)
v4-0001-Add-general-use-struct-and-callback-to-read-strea.patch introduced
this update to the read_stream_get_block() header comment, but we're not
changing read_stream_get_block() here. I reverted this.
Pushed with some other cosmetic changes.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2024-09-03 17:59:30 | Re: list of acknowledgments for PG17 |
| Previous Message | Mark Dilger | 2024-09-03 17:26:11 | Re: Index AM API cleanup |