| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index AM API cleanup |
| Date: | 2024-09-10 08:10:31 |
| Message-ID: | c96e58c8-db51-4ce7-b795-6f321e44d147@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.09.24 19:26, Mark Dilger wrote:
>> On Sep 3, 2024, at 9:52 AM, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Here is a cleaned-up version of the v17-0004 patch. I have applied the renaming discussed above. I have also made a wrapper function btgettreeheight() that calls _bt_getrootheight(). That way, if we ever want to change the API, we don't have to change _bt_getrootheight(), or disentangle it then. I've also added documentation and put in a source code comment that the API could be expanded for additional uses.
>
> Ok.
>
>> Also, I have removed the addition to the IndexOptInfo struct; that didn't seem necessary.
>
> Good catch. I agree with the change.
I have committed this patch. (It needed another small change to silence
a compiler warning about an uninitialized variable.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-09-10 08:10:33 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Peter Eisentraut | 2024-09-10 08:01:22 | Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~? |