From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |
Date: | 2020-04-17 20:43:11 |
Message-ID: | D12D03F7-211F-4585-B5F0-C5FF4CF6F61E@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
> On 17 Apr 2020, at 22:32, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Only provide openssl_tls_init_hook if building with openssl
>
> One or the other of these patches broke building without --with-openssl:
>
> fe-secure.c:435: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'PQgetSSLKeyPassHook'
> fe-secure.c:441: error: expected ')' before 'hook'
> fe-secure.c:447: warning: no previous prototype for 'PQdefaultSSLKeyPassHook'
> make[3]: *** [fe-secure.o] Error 1
fe-secure.c provides dummy implementations for non-SSL builds, and have a dummy
PQsslKeyPassHook_type implementation there. So either the dummy needs to be
removed if we want this hook OpenSSL specific as well, or the USE_OPENSSL
guards from 9e24109f1a4e4d8d1d keeping them only for openssl_tls_init_hook.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2020-04-17 20:52:08 | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |
Previous Message | Tom Lane | 2020-04-17 20:32:19 | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |