| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |
| Date: | 2020-04-18 12:44:52 |
| Message-ID: | 20200418124452.GF350229@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Apr 17, 2020 at 10:43:11PM +0200, Daniel Gustafsson wrote:
> fe-secure.c provides dummy implementations for non-SSL builds, and have a dummy
> PQsslKeyPassHook_type implementation there. So either the dummy needs to be
> removed if we want this hook OpenSSL specific as well, or the USE_OPENSSL
> guards from 9e24109f1a4e4d8d1d keeping them only for openssl_tls_init_hook.
I was just looking at the git history and bumped into this thread. I
think Andrew got it right to revert 9e24109 with 6741cfa: these
routines should be declared and return dummy results for non-SSL
builds or applications are going to have a hard time maintaining
compatibility with libpq depending on what they link to if they get to
call those SSL new routines.
PS: Thanks for f342d7a.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-18 18:03:04 | pgsql: Fix race conditions in synchronous standby management. |
| Previous Message | David Rowley | 2020-04-18 02:11:49 | pgsql: Fix possible crash with GENERATED ALWAYS columns |