| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |
| Date: | 2020-04-17 20:52:08 |
| Message-ID: | 670beaf0-5193-982c-3777-531b28ced1bb@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 4/17/20 4:32 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Only provide openssl_tls_init_hook if building with openssl
> One or the other of these patches broke building without --with-openssl:
>
> fe-secure.c:435: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'PQgetSSLKeyPassHook'
> fe-secure.c:441: error: expected ')' before 'hook'
> fe-secure.c:447: warning: no previous prototype for 'PQdefaultSSLKeyPassHook'
> make[3]: *** [fe-secure.o] Error 1
>
>
I am not batting 1000 today. Apologies to all.
Looks like the libpq change should be reverted. I'll double check.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2020-04-17 21:05:33 | pgsql: Revert "Only provide new libpq sslpasskey hook for openssl-enabl |
| Previous Message | Daniel Gustafsson | 2020-04-17 20:43:11 | Re: pgsql: Only provide openssl_tls_init_hook if building with openssl |