Re: websearch_to_tsquery() returns queries that don't match to_tsvector()

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Valentin Gatien-Baron <valentin(dot)gatienbaron(at)gmail(dot)com>, Teodor Sigaev <teodor(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>
Subject: Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Date: 2021-05-02 17:57:00
Message-ID: CAPpHfdsbr7OX+9F3S8igH5fJkyQwE_g5J4DMEiLwM0=4+nQxZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sun, May 2, 2021 at 8:52 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > It seems there is another bug with phrase search and query parsing.
> > It seems to me that since 0c4f355c6a websearch_to_tsquery() should
> > just parse text in quotes as a single token. Besides fixing this bug,
> > it simplifies the code.
>
> OK ...
>
> > Trying to fix this bug before 0c4f355c6a doesn't seem to worth the efforts.
>
> Agreed, plus it doesn't sound like the sort of behavior change that
> we want to push out in minor releases.

+1

> > I propose to push the attached patch to v14. Objections?
>
> This patch seems to include some unrelated fooling around in GiST?

Ooops, I've included this by oversight. The next revision is attached.

Anything besides that?

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
0001-Make-websearch_to_tsquery-parse-text-in-quotes-as-v2.patch application/octet-stream 6.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2021-05-02 18:04:56 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Previous Message Tom Lane 2021-05-02 17:52:27 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-05-02 18:04:56 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Previous Message Tom Lane 2021-05-02 17:52:27 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()