From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Valentin Gatien-Baron <valentin(dot)gatienbaron(at)gmail(dot)com>, Teodor Sigaev <teodor(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru> |
Subject: | Re: websearch_to_tsquery() returns queries that don't match to_tsvector() |
Date: | 2021-05-02 18:04:56 |
Message-ID: | 3712828.1619978696@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> Ooops, I've included this by oversight. The next revision is attached.
> Anything besides that?
Some quick eyeball review:
+ /* Everything is quotes is processed as a single token */
Should read "Everything in quotes ..."
- /* or else gettoken_tsvector() will raise an error */
+ /* or else ƒtsvector() will raise an error */
Looks like an unintentional change?
@@ -846,7 +812,6 @@ parse_tsquery(char *buf,
state.buffer = buf;
state.buf = buf;
state.count = 0;
- state.in_quotes = false;
state.state = WAITFIRSTOPERAND;
state.polstr = NIL;
This change seems wrong/unsafe too.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Zhihong Yu | 2021-05-02 18:09:49 | Re: websearch_to_tsquery() returns queries that don't match to_tsvector() |
Previous Message | Alexander Korotkov | 2021-05-02 17:57:00 | Re: websearch_to_tsquery() returns queries that don't match to_tsvector() |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhihong Yu | 2021-05-02 18:09:49 | Re: websearch_to_tsquery() returns queries that don't match to_tsvector() |
Previous Message | Alexander Korotkov | 2021-05-02 17:57:00 | Re: websearch_to_tsquery() returns queries that don't match to_tsvector() |