Re: websearch_to_tsquery() returns queries that don't match to_tsvector()

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Valentin Gatien-Baron <valentin(dot)gatienbaron(at)gmail(dot)com>, Teodor Sigaev <teodor(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>
Subject: Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Date: 2021-05-02 18:09:49
Message-ID: CALNJ-vR9F+ju2zVqkjxuGGR==HcZq7TUQAwK04wE0iFV5hBccg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sun, May 2, 2021 at 10:57 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com>
wrote:

> On Sun, May 2, 2021 at 8:52 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > > It seems there is another bug with phrase search and query parsing.
> > > It seems to me that since 0c4f355c6a websearch_to_tsquery() should
> > > just parse text in quotes as a single token. Besides fixing this bug,
> > > it simplifies the code.
> >
> > OK ...
> >
> > > Trying to fix this bug before 0c4f355c6a doesn't seem to worth the
> efforts.
> >
> > Agreed, plus it doesn't sound like the sort of behavior change that
> > we want to push out in minor releases.
>
> +1
>
> > > I propose to push the attached patch to v14. Objections?
> >
> > This patch seems to include some unrelated fooling around in GiST?
>
> Ooops, I've included this by oversight. The next revision is attached.
>
> Anything besides that?
>
> ------
> Regards,
> Alexander Korotkov
>

Hi,
+ /* Everything is quotes is processed as a single token
*/

is quotes -> in quotes

+ /* iterate to the closing quotes or end of the string*/

closing quotes -> closing quote

+ /* or else ƒtsvector() will raise an error */

The character before tsvector() seems to be special.

Cheers

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alexander Korotkov 2021-05-02 18:12:11 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Previous Message Tom Lane 2021-05-02 18:04:56 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2021-05-02 18:12:11 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()
Previous Message Tom Lane 2021-05-02 18:04:56 Re: websearch_to_tsquery() returns queries that don't match to_tsvector()