Re: PG_TEST_EXTRA and meson

On Wed, Jul 17, 2024 at 8:01 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> > Personally I use the config-time PG_TEST_EXTRA extensively. I'd be sad
> > to see it go, especially if developers are no longer forced to use it.
>
> The existing and documented expectation is that PG_TEST_EXTRA is an
> environment variable, ie it's a runtime option not a configure option.
> Making it be the latter seems like a significant loss of flexibility
> to me.

I think/hope we're saying the same thing -- developers should not be
forced to lock PG_TEST_EXTRA into their configurations; that's
inflexible and unhelpful.

What I'm saying in addition to that is, I really like that I can
currently put a default PG_TEST_EXTRA into my meson config so that I
don't have to keep track of it, and I do that all the time. So I'm in
favor of the "option 3" approach.

Thanks,
--Jacob