Re: PG_TEST_EXTRA and meson

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PG_TEST_EXTRA and meson
Date: 2024-07-17 15:01:04
Message-ID: 3552411.1721228464@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> On Wed, Jul 17, 2024 at 3:34 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>> Sorry, the previous reply was wrong; I misunderstood what you said.
>> Yes, that is how the patch was coded and I agree that getting rid of
>> config time PG_TEST_EXTRA could be a better alternative.

> Personally I use the config-time PG_TEST_EXTRA extensively. I'd be sad
> to see it go, especially if developers are no longer forced to use it.

The existing and documented expectation is that PG_TEST_EXTRA is an
environment variable, ie it's a runtime option not a configure option.
Making it be the latter seems like a significant loss of flexibility
to me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2024-07-17 15:07:16 Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin
Previous Message Andrew Dunstan 2024-07-17 14:53:36 Re: Windows perl/tcl requirement documentation