Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Hi Akshay,

I have resolved all the review comments and also updated the test cases as
per the new implementation.

PFA updated patch.

On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Nikhil
>
> Following are the initial review comments:
>
> - Open View/Edit data on any table and click on the same database
> connection and then click on the Execute button. Got "get_primary_keys()
> takes 1 positional argument but 2 were given" error.
> - In my opinion, we should hide the option to change the database
> connection for View/Edit Data.
> - If the user clicks on the same database connection multiple times
> then no need to change the backend connection and transaction id. Add
> validation at the backend, no action required in this case.
> - The role option is missing from the "connect to server" dialog.
> - The Password field should not be there on the "connect to server"
> dialog. Sometimes we saved the password so asking a password every time is
> not correct. Check the pgAdmin 3 behavior.
>
> Code review still remains.
>
> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> Regarding RM-3794 <https://redmine.postgresql.org/issues/3794> allow
>> the user to change the database connection from an open query tool:
>> I have implemented the feature and also added documentation for it.
>>
>> PFA patch.
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>