From: | Azad Salahlı <azad(dot)salahli(at)gmail(dot)com> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | [pgAdmin] Fix incorrect import in setup.py |
Date: | 2020-09-24 08:01:46 |
Message-ID: | CA+xqhcXzr-iSA5SDsKN5MbgC6i+AM-hRb5Pt+QjSaS20cRgEZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
First time posting here. I've attached a fix for an incorrect import
in `setup.py`. Trying to import from `pgadmin` before adding the root
directory to the system path results in import error, when the script
is invoked in any other way than running it directly. For example
$ /path/to/venv/bin/pip install pgadmin4
$ /path/to/venv/bin/python -m pgadmin4.setup
Traceback (most recent call last):
...
File "/path/to/venv/lib/python3.6/site-packages/pgadmin4/setup.py",
line 18, in <module>
from pgadmin.model import db, User, Version, ServerGroup, Server, \
ModuleNotFoundError: No module named 'pgadmin'
Please let me know what you think. Happy to address any feedback.
Regards,
Azad Salahlı
Attachment | Content-Type | Size |
---|---|---|
import_fix.diff | text/plain | 652 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Nikhil Mohite | 2020-09-28 05:50:11 | Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab |
Previous Message | Akshay Joshi | 2020-09-24 07:54:36 | pgAdmin 4 commit: Ensure that the 'Remove Server' option should be visi |