From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Azad Salahlı <azad(dot)salahli(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin] Fix incorrect import in setup.py |
Date: | 2020-09-28 11:18:17 |
Message-ID: | CAM9w-_mSZoJRJHu3_3uQ2A_OG0w_ft3SAQb6SViFP+koUrwiQA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Azad,
The patch looks good to me.
On Thu, Sep 24, 2020 at 6:33 PM Azad Salahlı <azad(dot)salahli(at)gmail(dot)com> wrote:
> Hi,
>
> First time posting here. I've attached a fix for an incorrect import
> in `setup.py`. Trying to import from `pgadmin` before adding the root
> directory to the system path results in import error, when the script
> is invoked in any other way than running it directly. For example
>
> $ /path/to/venv/bin/pip install pgadmin4
> $ /path/to/venv/bin/python -m pgadmin4.setup
> Traceback (most recent call last):
> ...
> File "/path/to/venv/lib/python3.6/site-packages/pgadmin4/setup.py",
> line 18, in <module>
> from pgadmin.model import db, User, Version, ServerGroup, Server, \
> ModuleNotFoundError: No module named 'pgadmin'
>
> Please let me know what you think. Happy to address any feedback.
>
> Regards,
> Azad Salahlı
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-09-28 12:25:12 | pgAdmin 4 commit: Added useful message when the explain plan is not use |
Previous Message | Aditya Toshniwal | 2020-09-28 09:52:47 | [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS |