From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Patch to remove Python 2.7 support in the macOS Appbundle |
Date: | 2020-05-04 06:32:49 |
Message-ID: | CANxoLDf6U6nnMKYveCw-LxY3y1wAEdyeTrMt_+aw=tc0Z7uYeQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave
On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Akshay, are you happy with this patch?
>
The patch is not applied to the latest code.
>
> On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> The code looks good to me. The package building was tested by Neel and
>>> we found that the venv was built with Python 3+ but the runtime was built
>>> against Python 2.7.
>>> As per Dave, Neel may have not used a venv of the correct version as it
>>> is working fine on Dav'e system. So, we can commit the patch.
>>>
>>
>> Yeah, that's not ideal, but the same problem exists today. I need to
>> spend some time figuring out how to make that more robust.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Satish V | 2020-05-04 07:17:10 | Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu |
Previous Message | Ganesh Jaybhay | 2020-05-04 05:30:47 | [pgAdmin][5469] SSL mode dropdown hover in create server dialog is not consistent with other select2 |