From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: Patch to remove Python 2.7 support in the macOS Appbundle |
Date: | 2020-05-01 11:51:45 |
Message-ID: | CA+OCxoxsr+hDf4LhU_=F74QgrRw-_KLoZi_DRubMf0mVuj_aKw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Akshay, are you happy with this patch?
On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> The code looks good to me. The package building was tested by Neel and we
>> found that the venv was built with Python 3+ but the runtime was built
>> against Python 2.7.
>> As per Dave, Neel may have not used a venv of the correct version as it
>> is working fine on Dav'e system. So, we can commit the patch.
>>
>
> Yeah, that's not ideal, but the same problem exists today. I need to spend
> some time figuring out how to make that more robust.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2020-05-01 14:14:06 | pgAdmin 4 commit: Rename the README and fix it up to match modern reali |
Previous Message | Dave Page | 2020-05-01 09:16:32 | Re: [pgAdmin][RM5455] Cleanup pgAdmin.py |