Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool
Date: 2020-01-31 06:15:10
Message-ID: CANxoLDeR-Hy_0VBg-DNN=G-yt1ZOGnMgZg0RQ8J1Mh06quv5nA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> PFA updated patch.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Ganesh
>>
>> Following are the review comments:
>>
>> - Focus is going on Table headers but it is not visible.
>> - Need to handle keyboard events on table header for sorting.
>> - Add tabindex property for the table rows.
>> - Add keyboard events to select the file from the file dialog.
>>
>>
>> On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <
>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached minor fix for tab navigation on footer and
>>> confirmation dialog buttons from file manager dialogue
>>> Kindly review.
>>>
>>> Regards,
>>> Ganesh Jaybhay
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-01-31 06:15:25 Re: [pgAdmin][RM5000] Logout the inactive session
Previous Message Akshay Joshi 2020-01-31 06:14:28 pgAdmin 4 commit: Fixed an issue where logout inactive session did not