| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool |
| Date: | 2020-01-28 06:30:47 |
| Message-ID: | CAKKotZSovKceo_vaCbzPWDZ+POH75NkZRnRpARQc1mTPPKjkLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
PFA updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Ganesh
>
> Following are the review comments:
>
> - Focus is going on Table headers but it is not visible.
> - Need to handle keyboard events on table header for sorting.
> - Add tabindex property for the table rows.
> - Add keyboard events to select the file from the file dialog.
>
>
> On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <
> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached minor fix for tab navigation on footer and
>> confirmation dialog buttons from file manager dialogue
>> Kindly review.
>>
>> Regards,
>> Ganesh Jaybhay
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM5107_v3.patch | application/x-patch | 16.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2020-01-28 06:32:32 | Re: [pgAdmin4][Patch]: Schema Diff Fixes |
| Previous Message | Akshay Joshi | 2020-01-28 06:09:11 | Re: [pgAdmin][RM4763][RM4762] Allow screen readers to identify errors and read description of non-textable elements. |