From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool |
Date: | 2020-02-06 05:00:00 |
Message-ID: | CAKKotZSATaG_ANAQ=JsKDvPuOrvB_Q2_dfH=NREuh2QYwVtw6A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please find a fix for two issues reported by QA team,
- Show focus when the Tab key is pressed
- Pressing the Enter key on C:\ drive does not open it on Windows
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jan 31, 2020 at 11:45 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> PFA updated patch.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>>
>> On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Ganesh
>>>
>>> Following are the review comments:
>>>
>>> - Focus is going on Table headers but it is not visible.
>>> - Need to handle keyboard events on table header for sorting.
>>> - Add tabindex property for the table rows.
>>> - Add keyboard events to select the file from the file dialog.
>>>
>>>
>>> On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <
>>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached minor fix for tab navigation on footer and
>>>> confirmation dialog buttons from file manager dialogue
>>>> Kindly review.
>>>>
>>>> Regards,
>>>> Ganesh Jaybhay
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
RM_5107_IE11_fix.diff | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fahar Abbas | 2020-02-06 12:41:02 | Re: pgAdmin4 v4.18 candidate builds |
Previous Message | Akshay Joshi | 2020-02-05 11:39:15 | Re: pgAdmin4 v4.18 candidate builds |