Re: Patch for SonarQube code scan fixes.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for SonarQube code scan fixes.
Date: 2020-09-09 05:58:05
Message-ID: CANxoLDeMg5nqxnKM_H3j3cVLGFJEzB4Dtrm6rqUBDLA4PJQ+Bg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied. I haven't committed changes for
"sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. psycopg2/connection:
>
> - Refactor this function to reduce its Cognitive Complexity from 32 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 17 to
> the 15 allowed.
>
> 2. psycopg2/server_manager:
>
> - Refactor this function to reduce its Cognitive Complexity from 20 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 33 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 26 to
> the 15 allowed.
>
> 3. sqlautocomplete/parseutils:
>
> - Refactor this function to reduce its Cognitive Complexity from 23 to
> the 15 allowed.
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-09-09 06:09:15 Re: [pgAdmin][RM5794] Excessive CPU usage while browser is idle
Previous Message Akshay Joshi 2020-09-09 05:56:39 Re: [pgAdmin][SonarQube] Reduce cognitive complexity