From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5794] Excessive CPU usage while browser is idle |
Date: | 2020-09-09 06:09:15 |
Message-ID: | CAM9w-_nAgMea=F9Yk_psM0e=jDb9Q+Cqt3qUzgomNvnRTSOQzw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
In the previous patch, I had changed the react state directly, which is not
recommended and can cause unpredictable behavior.
Attached patch changes the previous commit to avoid changing state directly.
Please review.
On Mon, Sep 7, 2020 at 6:48 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Mon, Sep 7, 2020 at 3:59 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to stop the indefinite growth of graph dataset.
>> This has caused excessive CPU usage and the patch will reduce it.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM5794.part2.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-09-09 07:39:49 | pgAdmin 4 commit: 1) Changing the state of the react directly is not re |
Previous Message | Akshay Joshi | 2020-09-09 05:58:05 | Re: Patch for SonarQube code scan fixes. |