| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
| Date: | 2020-09-09 05:56:39 |
| Message-ID: | CANxoLDfxtdR04OjvbjaxJjGQ4nCwSS+7kW6GM5a457b34s27Lw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Sep 8, 2020 at 6:13 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Attached patch reduces the cognitive complexity as below:
> web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15
> web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15
> web/setup.py - 17 to 15
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-09-09 05:58:05 | Re: Patch for SonarQube code scan fixes. |
| Previous Message | Akshay Joshi | 2020-09-09 05:56:01 | pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu |