Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Anthony

On which operating system you were running the test cases. On my OSX
machine only two test cases are failing which I have mentioned in my
previous email, but when I tried it on Ubuntu 16, most of the test cases
are failing because FireFox unable to mouse hover on "Object -> Create->"
menu to open the "Server" sub menu to add new server. To fix that I have
added following code:

cap = DesiredCapabilities.FIREFOX
cap['requireWindowFocus'] = True
cap['enablePersistentHover'] = False

By adding above that problem is resolved. Two test cases are still failing
on my machine (CopySelectedQueryResultsFeatureTest and CheckForViewDataTest).
Attached is the modified patch (included Anthony's patch).

On Mon, May 7, 2018 at 10:59 PM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:

> Hey Akshay,
>
> Unfortunately, I’m seeing far more failures on my machine with Firefox to
> be sure what you’re seeing, when you run these tests. However, I was able
> to address one of the areas that I saw multiple sleeps added and made the
> code more robust with Waits. The changes below to the file at
> .../pgadmin4/web/pgadmin/feature_tests/xss_checks_file_manager_test.py
> specifically wait for the element to be detached off the DOM and then to be
> reattached before retrieving any more attributes.
>
> instantiate the element using an anonymous function that takes the
> selector method
>
> [image: Screenshot from 2018-05-07 13-17-40.png]
>
> add a new reusable method to the page object that waits for attach/detach
>
> [image: Screenshot from 2018-05-07 13-18-40.png]
>
> I’ve attached my changes as the file *0002-RM_3270_v5.patch* for you to
> compare. If you’re unable to get some of these other issues, let me know
> and we can get through this!
>
>
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*