| From: | Anthony Emengo <aemengo(at)pivotal(dot)io> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |
| Date: | 2018-05-07 17:29:51 |
| Message-ID: | CAG8BBZPqQ+z2nP=GL4weOhurRgzfHxdE_G-ztAMSOeipWbkf3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hey Akshay,
Unfortunately, I’m seeing far more failures on my machine with Firefox to
be sure what you’re seeing, when you run these tests. However, I was able
to address one of the areas that I saw multiple sleeps added and made the
code more robust with Waits. The changes below to the file at
.../pgadmin4/web/pgadmin/feature_tests/xss_checks_file_manager_test.py
specifically wait for the element to be detached off the DOM and then to be
reattached before retrieving any more attributes.
instantiate the element using an anonymous function that takes the selector
method
[image: Screenshot from 2018-05-07 13-17-40.png]
add a new reusable method to the page object that waits for attach/detach
[image: Screenshot from 2018-05-07 13-18-40.png]
I’ve attached my changes as the file *0002-RM_3270_v5.patch* for you to
compare. If you’re unable to get some of these other issues, let me know
and we can get through this!
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-RM_3270_v5.patch | text/x-patch | 8.1 KB |
| 0002-RM_3270_v5.patch | text/x-patch | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-05-07 19:01:08 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |
| Previous Message | Akshay Joshi | 2018-05-07 10:35:48 | Re: [pgAdmin4][Patch]: Fix layout of the error message in the query tool |