Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

From: Anthony Emengo <aemengo(at)pivotal(dot)io>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Date: 2018-05-08 16:03:53
Message-ID: CAG8BBZMWWmbwpJb8WeahKPS83=upV+eOLcHFzef4Xd9TYubZyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hey,

Thanks for the extra details. We were running them on our Ubuntu machine,
but today we tried on OSX.

With *CheckForViewDataTest*:
The problem is that the chromedriver implicitly scrolls to an element when
moveToElement was called, but the Firefox did not.

https://github.com/mozilla/geckodriver/issues/776. To fix, we simply
scrolled to the element before the action was called:

[image: Screen Shot 2018-05-08 at 11.25.00 AM.png]

With *CopySelectedQueryResultsFeatureTest*:
We noticed that there’s different selection behavior between Firefox and
Chrome. In Firefox, the entire column is selected, whereas only the cell is
selected in Chrome. After reviewing, we think that modifying the assertion
to be a *assertIn* more ideal.

[image:
CopySelectedQueryResultsFeatureTest-2018.05.08_11.27.56-Python-3.6.5.png]
Also, just wanted to note that we had to bump the retry attempts to 60, to
see the Firefox run on our machine. Attached is the modified patch (with
all of our changes). If you need anything else, let me know!

Anthony and Victoria

Attachment Content-Type Size
RM_3270_v7.patch application/octet-stream 10.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Anthony Emengo 2018-05-08 22:28:50 Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Previous Message Victoria Henry 2018-05-08 13:59:48 Re: [pgAdmin4][RM#3298] Query tool shortcut issue